From 46679e84c310d0bd78a2de742334b53d332a8ca6 Mon Sep 17 00:00:00 2001
From: Claudio Cambra <claudio.cambra@nextcloud.com>
Date: Wed, 26 Mar 2025 13:24:05 +0100
Subject: [PATCH] gui/macOS: Avoid unnecessary retain on alloced objects

Fixes leaks

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
---
 src/gui/macOS/fileproviderdomainmanager_mac.mm      | 1 -
 src/gui/macOS/fileprovidersettingscontroller_mac.mm | 1 -
 src/gui/updater/sparkleupdater_mac.mm               | 3 ---
 3 files changed, 5 deletions(-)

diff --git a/src/gui/macOS/fileproviderdomainmanager_mac.mm b/src/gui/macOS/fileproviderdomainmanager_mac.mm
index 233d5adac..1e4807cd4 100644
--- a/src/gui/macOS/fileproviderdomainmanager_mac.mm
+++ b/src/gui/macOS/fileproviderdomainmanager_mac.mm
@@ -275,7 +275,6 @@ public:
 
             NSFileProviderDomain * const fileProviderDomain = [[NSFileProviderDomain alloc] initWithIdentifier:domainId.toNSString()
                                                                                                    displayName:domainDisplayName.toNSString()];
-            [fileProviderDomain retain];
 
             [NSFileProviderManager addDomain:fileProviderDomain completionHandler:^(NSError * const error) {
                 if(error) {
diff --git a/src/gui/macOS/fileprovidersettingscontroller_mac.mm b/src/gui/macOS/fileprovidersettingscontroller_mac.mm
index 9d083300c..d1fd68e69 100644
--- a/src/gui/macOS/fileprovidersettingscontroller_mac.mm
+++ b/src/gui/macOS/fileprovidersettingscontroller_mac.mm
@@ -194,7 +194,6 @@ public slots:
         [enumerator retain];
 
         FileProviderStorageUseEnumerationObserver *const storageUseObserver = [[FileProviderStorageUseEnumerationObserver alloc] init];
-        [storageUseObserver retain];
         storageUseObserver.enumerationFinishedHandler = ^(NSError *const error) {
             qCInfo(lcFileProviderSettingsController) << "Enumeration finished for" << domain.identifier;
             if (error != nil) {
diff --git a/src/gui/updater/sparkleupdater_mac.mm b/src/gui/updater/sparkleupdater_mac.mm
index 05c868e1e..7197ae807 100644
--- a/src/gui/updater/sparkleupdater_mac.mm
+++ b/src/gui/updater/sparkleupdater_mac.mm
@@ -248,13 +248,10 @@ SparkleUpdater::SparkleUpdater(const QUrl& appCastUrl)
     , _interface(std::make_unique<SparkleInterface>(this))
 {
     _interface->delegate = [[NCSparkleUpdaterDelegate alloc] initWithOwner:_interface.get()];
-    [_interface->delegate retain];
-
     _interface->updaterController =
         [[SPUStandardUpdaterController alloc] initWithStartingUpdater:YES 
                                                       updaterDelegate:_interface->delegate
                                                    userDriverDelegate:nil];
-    [_interface->updaterController retain];
 
     setUpdateUrl(appCastUrl);
 
-- 
2.30.2